add optimism velodrome v2 concentrated liquidity pool #7038
Conversation
|
How can i fix this? Was looking into the uniswap v3 macro and fee is optional. Also, the other ctes in the base script don't have a fee column. |
There was a problem hiding this comment.
Hi @0xdatawolf001,
you can add one or two lines of seed records in the corresponding seed file:
https://github.com/duneanalytics/spellbook/blob/main/dbt_subprojects/dex/seeds/trades/velodrome_optimism_base_trades_seed.csv
You can find more info in the readme here:
https://github.com/duneanalytics/spellbook/tree/main/dbt_subprojects/dex/models/trades#readme
dbt_subprojects/dex/models/trades/optimism/platforms/velodrome_optimism_base_trades.sql
Outdated
Show resolved
Hide resolved
Hosuke
added
in review
|
sorry for the delay! Here are the required changes. Just curious, is it possible to test this? I'm trying the test table. Maybe i'm botching the table name |
There was a problem hiding this comment.
LGTM.✅
Thank you @0xdatawolf001
You can test the data using above query by the way.
Hosuke
added
ready-for-final-review
and removed
in review
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
For adding to existing spell lineage
Editing the the velodrome optimism file based on this issue: Missing CLPool Contracts for Velodrome_v2 on Optimism in
dex.tradestable #6828let me know if something is not right!